Treat unknown MIME type as application/octet-stream when launching apps.

Treat unknown MIME type as application/octet-stream when launching apps.

Previously, if the MIME type of a file passed to a file handler of a
platform app, the app would be launched without the file, even if the
file handler accepted * or */*. With this change, a file with an unknown
MIME type is treated the same as one with a MIME type of
application/octet-stream.

BUG=219402
TEST=browser_test PlatformAppBrowserTest.LaunchNoType

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194789

[koz (OOO until 15th September), 2013-04-16 04:56:18]

lgtm with nits

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
File chrome/browser/extensions/platform_app_launcher.cc (right):

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:159: if
(!net::GetMimeTypeFromFile(file_path_, &mime_type)) {
nit: curlies are unnecessary now

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:160:
mime_type.assign(kFallbackMimeType);
Is this different to

mime_type = kFallbackMimeType

?

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:194: if (mime_type.empty()) {
nit: remove curlies

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:195:
LaunchWithMimeType(kFallbackMimeType);
nit: I think

LaunchWithMimeType(mime_type.empty() ? kFallbackMimeType : mime_type);

is slightly less redundant.

[Sam McNally, 2013-04-16 05:17:33]

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
File chrome/browser/extensions/platform_app_launcher.cc (right):

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:159: if
(!net::GetMimeTypeFromFile(file_path_, &mime_type)) {
On 2013/04/16 04:56:18, koz wrote:
> nit: curlies are unnecessary now

Done.

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:160:
mime_type.assign(kFallbackMimeType);
On 2013/04/16 04:56:18, koz wrote:
> Is this different to
> 
> mime_type = kFallbackMimeType
> 
> ?

No. Changed to assignment as it's probably clearer.

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:194: if (mime_type.empty()) {
On 2013/04/16 04:56:18, koz wrote:
> nit: remove curlies

Done.

https://codereview.chromium.org/14254002/diff/15001/chrome/browser/extensions...
chrome/browser/extensions/platform_app_launcher.cc:195:
LaunchWithMimeType(kFallbackMimeType);
On 2013/04/16 04:56:18, koz wrote:
> nit: I think
> 
> LaunchWithMimeType(mime_type.empty() ? kFallbackMimeType : mime_type);
> 
> is slightly less redundant.

Done.

[commit-bot: I haz the power, 2013-04-18 00:22:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sammc@chromium.org/14254002/23001

[commit-bot: I haz the power, 2013-04-18 05:51:45]

Change committed as 194789