Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: net/tools/quic/quic_client_session.h

Issue 1425363002: Factor QuicCryptoClientStream APIs into QuicCryptoClientStreamBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106313860
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_crypto_client_stream.cc ('k') | net/tools/quic/quic_client_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_client_session.h
diff --git a/net/tools/quic/quic_client_session.h b/net/tools/quic/quic_client_session.h
index 2f180d73757d80d2572283ad0e098e6e83290eb3..e04d1439a97abd1bc265b5c9cf38f30894353f84 100644
--- a/net/tools/quic/quic_client_session.h
+++ b/net/tools/quic/quic_client_session.h
@@ -30,10 +30,12 @@ class QuicClientSession : public QuicClientSessionBase {
const QuicServerId& server_id,
QuicCryptoClientConfig* crypto_config);
~QuicClientSession() override;
+ // Set up the QuicClientSession. Must be called prior to use.
+ void Initialize() override;
// QuicSession methods:
QuicSpdyClientStream* CreateOutgoingDynamicStream() override;
- QuicCryptoClientStream* GetCryptoStream() override;
+ QuicCryptoClientStreamBase* GetCryptoStream() override;
// QuicClientSessionBase methods:
void OnProofValid(const QuicCryptoClientConfig::CachedState& cached) override;
@@ -56,14 +58,22 @@ class QuicClientSession : public QuicClientSessionBase {
// QuicSession methods:
QuicSpdyStream* CreateIncomingDynamicStream(QuicStreamId id) override;
+ // Create the crypto stream. Called by Initialize()
+ virtual QuicCryptoClientStreamBase* CreateQuicCryptoStream();
+
// Unlike CreateOutgoingDynamicStream, which applies a bunch of sanity checks,
// this simply returns a new QuicSpdyClientStream. This may be used by
// subclasses which want to use a subclass of QuicSpdyClientStream for streams
// but wish to use the sanity checks in CreateOutgoingDynamicStream.
virtual QuicSpdyClientStream* CreateClientStream();
+ const QuicServerId& server_id() { return server_id_; }
+ QuicCryptoClientConfig* crypto_config() { return crypto_config_; }
+
private:
- scoped_ptr<QuicCryptoClientStream> crypto_stream_;
+ scoped_ptr<QuicCryptoClientStreamBase> crypto_stream_;
+ QuicServerId server_id_;
+ QuicCryptoClientConfig* crypto_config_;
// If this is set to false, the client will ignore server GOAWAYs and allow
// the creation of streams regardless of the high chance they will fail.
« no previous file with comments | « net/quic/quic_crypto_client_stream.cc ('k') | net/tools/quic/quic_client_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698