Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1425353002: PPC: [es6] Better support for built-ins subclassing. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Better support for built-ins subclassing. Port 4490ce85205d3504dc0bf444f5e8b3deb04cbb06 Original commit message: Create proper initial map for original constructor (new.target) instead of doing prototype transition on the base constructor's initial map. This approach fixes in-object slack tracking for subclass instances. This CL also fixes subclassing from String. It also fixes typed array map smashing done during typed array initialization. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:3101, v8:3330, v8:4419 LOG=N Committed: https://crrev.com/5a8da4945c6342603c719059e5830b0e0ae02fc1 Cr-Commit-Position: refs/heads/master@{#31720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M src/ppc/builtins-ppc.cc View 4 chunks +32 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-02 15:48:33 UTC) #1
Igor Sheludko
lgtm
5 years, 1 month ago (2015-11-02 19:27:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425353002/1
5 years, 1 month ago (2015-11-02 19:33:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 19:51:54 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 19:52:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a8da4945c6342603c719059e5830b0e0ae02fc1
Cr-Commit-Position: refs/heads/master@{#31720}

Powered by Google App Engine
This is Rietveld 408576698