Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1425333002: Use inline constants instead of typed array for math constants. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use inline constants instead of typed array for math constants. R=bmeurer@chromium.org Committed: https://crrev.com/3e98f04d1ca1f49df0c2ee0269c6f19522c5550c Cr-Commit-Position: refs/heads/master@{#31710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -142 lines) Patch
M src/bootstrapper.cc View 3 chunks +1 line, -9 lines 0 comments Download
M src/js/prologue.js View 1 chunk +2 lines, -3 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 14 chunks +69 lines, -56 lines 0 comments Download
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 1 month ago (2015-11-02 10:20:45 UTC) #1
Benedikt Meurer
Nice, thanks. LGTM!
5 years, 1 month ago (2015-11-02 10:21:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425333002/1
5 years, 1 month ago (2015-11-02 10:26:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/9612)
5 years, 1 month ago (2015-11-02 10:33:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425333002/1
5 years, 1 month ago (2015-11-02 12:10:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 12:21:17 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 12:21:55 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3e98f04d1ca1f49df0c2ee0269c6f19522c5550c
Cr-Commit-Position: refs/heads/master@{#31710}

Powered by Google App Engine
This is Rietveld 408576698