content/renderer/history_controller.cc - Issue 1425303002: OOPIF: Stop using HistoryController and refactor UpdateState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/history_controller.cc

Issue 1425303002: OOPIF: Stop using HistoryController and refactor UpdateState. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/public/test/render_view_test.cc ('k') | content/renderer/history_controller_browsertest.cc » ('j') | testing/buildbot/chromium.fyi.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/history_controller.cc

diff --git a/content/renderer/history_controller.cc b/content/renderer/history_controller.cc

index 225f71748afa19537689e5e294e28b70faec1c78..2507403f1b75a3a1877e4f089528fd1043c87e9d 100644

--- a/content/renderer/history_controller.cc

+++ b/content/renderer/history_controller.cc

@@ -36,6 +36,7 @@

#include "content/renderer/history_controller.h"

#include "content/common/navigation_params.h"

+#include "content/common/site_isolation_policy.h"

#include "content/renderer/render_frame_impl.h"

#include "content/renderer/render_view_impl.h"

#include "third_party/WebKit/public/web/WebFrameLoadType.h"

@@ -50,6 +51,8 @@ namespace content {

HistoryController::HistoryController(RenderViewImpl* render_view)

: render_view_(render_view) {

+ // We don't use HistoryController in OOPIF enabled modes.

+ DCHECK(!SiteIsolationPolicy::UseSubframeNavigationEntries());

Avi (use Gerrit) 2015/11/04 19:51:30 🎉

}

HistoryController::~HistoryController() {