Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1425303002: OOPIF: Stop using HistoryController and refactor UpdateState. (Closed)

Created:
5 years, 1 month ago by Charlie Reis
Modified:
5 years, 1 month ago
Reviewers:
Avi (use Gerrit), nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, jochen+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OOPIF: Stop using HistoryController and refactor UpdateState. In OOPIF-enabled builds, we no longer need to track the current HistoryEntry or use HistoryController. Instead, the current WebHistoryItem is stored on each RenderFrame. This also moves UpdateState to RenderFrame{Host}, ensuring that PageState objects can be stored on each frame's FrameNavigationEntry. These changes only affect Chrome with --site-per-process or --isolate-extensions. BUG=545219, 236848 Committed: https://crrev.com/8eb8ef2a49fe5faae46eb229ff8de313e4c4694e Cr-Commit-Position: refs/heads/master@{#357921}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Clean up #

Total comments: 4

Patch Set 6 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -60 lines) Patch
M chrome/browser/chrome_content_browser_client_browsertest.cc View 1 2 3 4 1 chunk +16 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 3 chunks +31 lines, -8 lines 0 comments Download
M content/common/frame_messages.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/render_view_test.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 3 4 2 chunks +14 lines, -2 lines 0 comments Download
M content/renderer/history_controller.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/history_controller_browsertest.cc View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 10 chunks +48 lines, -23 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 4 chunks +5 lines, -10 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 3 chunks +10 lines, -8 lines 0 comments Download
M content/test/layouttest_support.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M content/test/test_render_frame.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 2 3 4 2 chunks +8 lines, -5 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Charlie Reis
This is a big step toward where we want to be in OOPIF modes. We ...
5 years, 1 month ago (2015-11-04 18:42:42 UTC) #3
Avi (use Gerrit)
So each frame now has an entire "PageState" with just its state, and so on? ...
5 years, 1 month ago (2015-11-04 19:51:30 UTC) #4
Charlie Reis
On 2015/11/04 19:51:30, Avi wrote: > So each frame now has an entire "PageState" with ...
5 years, 1 month ago (2015-11-04 19:59:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425303002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425303002/100001
5 years, 1 month ago (2015-11-04 20:00:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/115587)
5 years, 1 month ago (2015-11-04 20:13:24 UTC) #9
Charlie Reis
Nasko, can you take a look at frame_messages.h for IPC owners?
5 years, 1 month ago (2015-11-04 20:55:12 UTC) #11
nasko
LGTM with a nit. https://codereview.chromium.org/1425303002/diff/100001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/1425303002/diff/100001/content/browser/web_contents/web_contents_impl.cc#newcode4082 content/browser/web_contents/web_contents_impl.cc:4082: frame_entry->set_page_state(page_state); nit: Empty line after ...
5 years, 1 month ago (2015-11-04 21:12:29 UTC) #12
Charlie Reis
Thanks! https://codereview.chromium.org/1425303002/diff/100001/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/1425303002/diff/100001/content/browser/web_contents/web_contents_impl.cc#newcode4082 content/browser/web_contents/web_contents_impl.cc:4082: frame_entry->set_page_state(page_state); On 2015/11/04 21:12:29, nasko (slow to review) ...
5 years, 1 month ago (2015-11-04 21:17:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425303002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425303002/140001
5 years, 1 month ago (2015-11-04 21:18:05 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:140001)
5 years, 1 month ago (2015-11-04 22:51:45 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 22:52:50 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8eb8ef2a49fe5faae46eb229ff8de313e4c4694e
Cr-Commit-Position: refs/heads/master@{#357921}

Powered by Google App Engine
This is Rietveld 408576698