Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/profile-generator-inl.h

Issue 14253015: Skip samples where top function's stack frame is not setup properly (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reverted build/common.gypi Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 const char* name, 48 const char* name,
49 const char* resource_name, 49 const char* resource_name,
50 int line_number, 50 int line_number,
51 int security_token_id) 51 int security_token_id)
52 : tag_(tag), 52 : tag_(tag),
53 name_prefix_(name_prefix), 53 name_prefix_(name_prefix),
54 name_(name), 54 name_(name),
55 resource_name_(resource_name), 55 resource_name_(resource_name),
56 line_number_(line_number), 56 line_number_(line_number),
57 shared_id_(0), 57 shared_id_(0),
58 security_token_id_(security_token_id) { 58 security_token_id_(security_token_id),
59 frame_setup_offset_(-1),
loislo 2013/04/26 13:36:56 please use -1 or the constant everywhere
loislo 2013/04/26 13:36:56 please use -1 or the constant everywhere
60 frame_destroy_offset_(-1) {
59 } 61 }
60 62
61 63
62 bool CodeEntry::is_js_function_tag(Logger::LogEventsAndTags tag) { 64 bool CodeEntry::is_js_function_tag(Logger::LogEventsAndTags tag) {
63 return tag == Logger::FUNCTION_TAG 65 return tag == Logger::FUNCTION_TAG
64 || tag == Logger::LAZY_COMPILE_TAG 66 || tag == Logger::LAZY_COMPILE_TAG
65 || tag == Logger::SCRIPT_TAG 67 || tag == Logger::SCRIPT_TAG
66 || tag == Logger::NATIVE_FUNCTION_TAG 68 || tag == Logger::NATIVE_FUNCTION_TAG
67 || tag == Logger::NATIVE_LAZY_COMPILE_TAG 69 || tag == Logger::NATIVE_LAZY_COMPILE_TAG
68 || tag == Logger::NATIVE_SCRIPT_TAG; 70 || tag == Logger::NATIVE_SCRIPT_TAG;
(...skipping 22 matching lines...) Expand all
91 case OTHER: 93 case OTHER:
92 case EXTERNAL: 94 case EXTERNAL:
93 return program_entry_; 95 return program_entry_;
94 default: return NULL; 96 default: return NULL;
95 } 97 }
96 } 98 }
97 99
98 } } // namespace v8::internal 100 } } // namespace v8::internal
99 101
100 #endif // V8_PROFILE_GENERATOR_INL_H_ 102 #endif // V8_PROFILE_GENERATOR_INL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698