Chromium Code Reviews

Issue 1425293009: [Android] Enhanced bookmark default mobile folder experiment. (Closed)

Created:
5 years, 1 month ago by Kibeom Kim (inactive)
Modified:
5 years, 1 month ago
Reviewers:
Ian Wen
CC:
chromium-reviews, Eli Wald
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Enhanced bookmark default mobile folder experiment. BUG=552508 Committed: https://crrev.com/964c0baff2687c52a43935fafca4ee07790b047e Cr-Commit-Position: refs/heads/master@{#358441}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+11 lines, -1 line)
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java View 3 chunks +11 lines, -1 line 0 comments

Messages

Total messages: 8 (2 generated)
Kibeom Kim (inactive)
5 years, 1 month ago (2015-11-06 19:41:13 UTC) #2
Ian Wen
lgtm. Please test it on M47 before merging.
5 years, 1 month ago (2015-11-06 22:10:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425293009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425293009/1
5 years, 1 month ago (2015-11-06 22:11:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 23:17:36 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/964c0baff2687c52a43935fafca4ee07790b047e Cr-Commit-Position: refs/heads/master@{#358441}
5 years, 1 month ago (2015-11-06 23:18:21 UTC) #7
Kibeom Kim (inactive)
5 years, 1 month ago (2015-11-13 19:03:06 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1445553003/ by kkimlabs@chromium.org.

The reason for reverting is: This CL had a bug that when experiment is turned
on, it always forwards all bookmarks to mobile folder..

Powered by Google App Engine