Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1425293007: [crankshaft] Do not optimize ClassConstructor calls and apply. (Closed)

Created:
5 years, 1 month ago by Camillo Bruni
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Do not optimize ClassConstructor calls and apply. LOG=N BUG=v8:4428 Committed: https://crrev.com/83f60ab5ac10f5a7b20321bb872df0ef00b9dc73 Cr-Commit-Position: refs/heads/master@{#31839}

Patch Set 1 #

Patch Set 2 : hope my magic works #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -39 lines) Patch
M src/crankshaft/hydrogen.cc View 1 3 chunks +8 lines, -1 line 0 comments Download
M src/parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 1 3 chunks +0 lines, -22 lines 0 comments Download
M test/mjsunit/es6/classes.js View 1 3 chunks +26 lines, -1 line 0 comments Download
M test/mjsunit/es6/debug-break-default-constructor.js View 1 chunk +6 lines, -6 lines 0 comments Download
M test/mjsunit/es6/debug-step-into-constructor.js View 6 chunks +5 lines, -6 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425293007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425293007/1
5 years, 1 month ago (2015-11-04 16:37:17 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 16:54:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425293007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425293007/20001
5 years, 1 month ago (2015-11-05 10:42:38 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-05 11:01:00 UTC) #8
Camillo Bruni
PTAL and tell me the 20 cases I forgot to take care of ;)
5 years, 1 month ago (2015-11-05 11:33:41 UTC) #10
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-11-05 19:19:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425293007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425293007/20001
5 years, 1 month ago (2015-11-05 19:19:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 19:21:12 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 19:21:29 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/83f60ab5ac10f5a7b20321bb872df0ef00b9dc73
Cr-Commit-Position: refs/heads/master@{#31839}

Powered by Google App Engine
This is Rietveld 408576698