Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1425293006: Move nav_entry_id from RenderViewHost to RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initial patch Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index fdf40d39f575c096abc51ea7ae4c0f0f222e02f5..ea91c32ffe87afe7fef003d6daf03ca5b60b431f 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3890,7 +3890,7 @@ void WebContentsImpl::UpdateState(RenderViewHost* rvh,
return;
NavigationEntryImpl* new_entry = controller_.GetEntryWithUniqueID(
- rvhi->nav_entry_id());
+ static_cast<RenderFrameHostImpl*>(rvhi->GetMainFrame())->nav_entry_id());
if (SiteIsolationPolicy::UseSubframeNavigationEntries()) {
// TODO(creis): We can't properly update state for cross-process subframes
@@ -4074,10 +4074,8 @@ void WebContentsImpl::UpdateTitle(RenderFrameHost* render_frame_host,
NavigationEntryImpl* entry = controller_.GetEntryWithPageID(
render_frame_host->GetSiteInstance(), page_id);
- RenderViewHostImpl* rvhi =
- static_cast<RenderViewHostImpl*>(render_frame_host->GetRenderViewHost());
NavigationEntryImpl* new_entry = controller_.GetEntryWithUniqueID(
- rvhi->nav_entry_id());
+ static_cast<RenderFrameHostImpl*>(render_frame_host)->nav_entry_id());
DCHECK_EQ(entry, new_entry);
// We can handle title updates when we don't have an entry in
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698