Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1425293006: Move nav_entry_id from RenderViewHost to RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initial patch Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index c2bc78d2f8ddea0e3597663fdea3163210e36d68..5cd1f249f487c5ea9dd621690681b51ace34ed81 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -250,6 +250,14 @@ class CONTENT_EXPORT RenderFrameHostImpl
// TODO(creis): Make bindings frame-specific, to support cases like <webview>.
int GetEnabledBindings();
+ // The unique ID of the latest NavigationEntry that this RenderFrameHost is
+ // showing. This may change even when this frame hasn't committed a page,
+ // such as for a new subframe navigation in a different frame.
+ int nav_entry_id() const { return nav_entry_id_; }
+ void set_nav_entry_id(int nav_entry_id) { nav_entry_id_ = nav_entry_id; }
+
+ // A NavigationHandle for the pending navigation in this frame, if any. This
+ // is cleared when the navigation commits.
NavigationHandleImpl* navigation_handle() const {
return navigation_handle_.get();
}
@@ -741,6 +749,13 @@ class CONTENT_EXPORT RenderFrameHostImpl
// tests.
bool pending_commit_;
+ // The unique ID of the latest NavigationEntry that this RenderFrameHost is
+ // showing. This may change even when this frame hasn't committed a page,
+ // such as for a new subframe navigation in a different frame. Tracking this
+ // allows us to send things like title and state updates to the latest
+ // relevant NavigationEntry.
+ int nav_entry_id_;
+
// Used to swap out or shut down this RFH when the unload event is taking too
// long to execute, depending on the number of active frames in the
// SiteInstance.
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698