Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1425293006: Move nav_entry_id from RenderViewHost to RenderFrameHost. (Closed)

Created:
5 years, 1 month ago by Charlie Reis
Modified:
5 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move nav_entry_id from RenderViewHost to RenderFrameHost. We update this value for every current RFH in the FrameTree on each new NavigationEntry commit. This allows us to track the latest entry that is relevant for each RFH, which is where UpdateTitle and UpdateState messages should apply. BUG=545219, 369661 TEST=No visible behavior change yet; will enable per-frame UpdateState. Committed: https://crrev.com/03b4800d12e115a95c5f0ee21c8f7ba3609dbcd3 Cr-Commit-Position: refs/heads/master@{#357690}

Patch Set 1 : Initial patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 2 chunks +14 lines, -7 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +15 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Charlie Reis
Avi, can you take a look? This unblocks the UpdateState refactor for OOPIFs (https://codereview.chromium.org/1425303002/), since ...
5 years, 1 month ago (2015-11-03 20:11:54 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425293006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425293006/20001
5 years, 1 month ago (2015-11-03 21:06:10 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 21:13:49 UTC) #7
Avi (use Gerrit)
lgtm Woot!
5 years, 1 month ago (2015-11-04 00:29:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425293006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425293006/20001
5 years, 1 month ago (2015-11-04 00:35:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-04 00:55:03 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 00:56:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03b4800d12e115a95c5f0ee21c8f7ba3609dbcd3
Cr-Commit-Position: refs/heads/master@{#357690}

Powered by Google App Engine
This is Rietveld 408576698