Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: src/compiler/access-info.cc

Issue 1425293004: [turbofan] Add support for named access to Number primitives. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/js-native-context-specialization.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/access-info.cc
diff --git a/src/compiler/access-info.cc b/src/compiler/access-info.cc
index 1603804d8e8f1d65d001f1839524dcfcd3ef90ea..ea93ed1ecb32c83369a9fd2f88fe75e13b5ddd9a 100644
--- a/src/compiler/access-info.cc
+++ b/src/compiler/access-info.cc
@@ -28,8 +28,7 @@ bool CanInlineElementAccess(Handle<Map> map) {
bool CanInlinePropertyAccess(Handle<Map> map) {
- // TODO(bmeurer): Add support for Number primitives.
- // if (map->instance_type() == HEAP_NUMBER_TYPE) return false;
+ if (map->instance_type() == HEAP_NUMBER_TYPE) return true;
if (map->instance_type() < FIRST_NONSTRING_TYPE) return true;
return map->IsJSObjectMap() && !map->is_dictionary_map() &&
!map->has_named_interceptor() &&
« no previous file with comments | « no previous file | src/compiler/js-native-context-specialization.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698