Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1425293004: [turbofan] Add support for named access to Number primitives. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for named access to Number primitives. Implement the missing bits for named access to Number values, which is basically always done on the Number prototype. Crankshaft only deals with Number primitives in the polymorphic case, while we generally support Numbers even for monomorphic access. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/608ed2e24f928d38c65f1ce71b4aa35c6b17190c Cr-Commit-Position: refs/heads/master@{#31731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -23 lines) Patch
M src/compiler/access-info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 6 chunks +51 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-03 06:33:12 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the "number stuff" TODO :-) Please take a look. ...
5 years, 1 month ago (2015-11-03 06:33:45 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-03 06:37:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425293004/1
5 years, 1 month ago (2015-11-03 06:40:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 06:56:13 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 06:56:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/608ed2e24f928d38c65f1ce71b4aa35c6b17190c
Cr-Commit-Position: refs/heads/master@{#31731}

Powered by Google App Engine
This is Rietveld 408576698