service/datastore: Call MGS GetAllMeta() in Save()

service/datastore/pls_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // adapted from github.com/golang/appengine/datastore
 
 package datastore
 
 import (
         "bytes"
@@ skipping 1730 matching lines @@
                         So(pls.Problem(), ShouldEqual, ErrInvalidEntityType)
 
                         Convey("the error PLS can still be used", func() {
                                 k, _ := pls.GetMeta("kind")
                                 So(k, ShouldBeNil)
 
                                 props := pls.GetAllMeta()
                                 So(props, ShouldResemble, PropertyMap{
                                         "$kind": []Property{mpNI("")},
                                 })
+
+                                _, err := pls.Save(true)
+                                So(err, ShouldNotBeNil)
                         })
                 })
 
                 Convey("convertible meta default types", func() {
                         type OKDefaults struct {
                                 When   string `gae:"$when,tomorrow"`
                                 Amount int64  `gae:"$amt,100"`
                                 DoIt   Toggle `gae:"$doit,on"`
                         }
                         okd := &OKDefaults{}
@@ skipping 103 matching lines @@
                         So(mgs.GetMetaDefault("id", ""), ShouldEqual, "moo|100")
                         So(mgs.GetMetaDefault("kind", ""), ShouldEqual, "CoolKind")
 
                         So(mgs.SetMeta("kind", "Something"), ShouldErrLike, "unexported field")
                         So(mgs.SetMeta("id", "happy|27"), ShouldBeNil)
 
                         So(idp.parent, ShouldEqual, "happy")
                         So(idp.id, ShouldEqual, 27)
 
                         So(mgs.GetAllMeta(), ShouldResemble, PropertyMap{
-                                "$id":   {MkPropertyNI("happy|27")},
-                                "$kind": {MkPropertyNI("CoolKind")},
+                                "$id":   {mpNI("happy|27")},
+                                "$kind": {mpNI("CoolKind")},
                         })
                 })
 
                 Convey("MetaGetterSetter implementation (KindOverride)", func() {
                         ko := &KindOverride{ID: 20}
                         mgs := getMGS(ko)
                         So(mgs.GetMetaDefault("kind", ""), ShouldEqual, "KindOverride")
 
                         ko.customKind = "something"
                         So(mgs.GetMetaDefault("kind", ""), ShouldEqual, "something")
 
                         So(mgs.SetMeta("kind", "Nerp"), ShouldBeNil)
                         So(ko.customKind, ShouldEqual, "Nerp")
 
                         So(mgs.SetMeta("kind", "KindOverride"), ShouldBeNil)
                         So(ko.customKind, ShouldEqual, "")
 
                         So(mgs.GetAllMeta(), ShouldResemble, PropertyMap{
-                                "$id":   {MkPropertyNI(20)},
-                                "$kind": {MkPropertyNI("KindOverride")},
+                                "$id":   {mpNI(20)},
+                                "$kind": {mpNI("KindOverride")},
                         })
                         ko.customKind = "wut"
                         So(mgs.GetAllMeta(), ShouldResemble, PropertyMap{
-                                "$id":   {MkPropertyNI(20)},
-                                "$kind": {MkPropertyNI("wut")},
+                                "$id":   {mpNI(20)},
+                                "$kind": {mpNI("wut")},
+                        })
+
+                        props, err := GetPLS(ko).Save(true)
+                        So(err, ShouldBeNil)
+                        So(props, ShouldResemble, PropertyMap{
+                                "$id":   {mpNI(20)},
+                                "$kind": {mpNI("wut")},
                         })
                 })
         })
 }