Issue 1425283002: service/datastore: Call MGS GetAllMeta() in Save()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1425283002: service/datastore: Call MGS GetAllMeta() in Save() (Closed)

Created:
5 years, 1 month ago by dnj

Modified:
5 years, 1 month ago

Reviewers:
iannucci

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://github.com/luci/gae@master

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

More Reviews

Description

service/datastore: Call MGS GetAllMeta() in Save() Fix a bug where a structPLS that uses Save(withMeta: true) will ignore its object's MetaGetterSetter overrides and use struct-default. R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/b455a3fad800d360fb9dbd781b23734eca5d68d7

Patch Set 1 #

Patch Set 2 : Add support/handling for invalid codec. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
	M	service/datastore/pls_impl.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
	M	service/datastore/pls_test.go	View	1	3 chunks	+16 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425283002/20001

5 years, 1 month ago (2015-11-02 20:45:37 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-11-02 20:48:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/b455a3fad800d360fb9dbd781b23734eca5d68d7

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages