Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1425243004:
Overflow-proof the computation of stack region end. (Closed)
|
Created:
5 years, 1 month ago by sof Modified:
5 years, 1 month ago CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOverflow-proof the computation of stack region end.
Add asserts + be more careful about type conversions when
computing the stack limit pointer value.
R=haraken
BUG=none
Committed: https://crrev.com/5ddc71a4449488d1f79405ac05431a7c198d21e0
Cr-Commit-Position: refs/heads/master@{#357569}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look. I'm mostly trying to diagnose this long-present flaky assert on the windows dbg bot, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpa... i.e., StackFrameDepth::s_stackFrameLimit being zero and s_isEnabled 'true', which I don't see how can (realistically) happen in practice.
Description was changed from ========== Overflow proof the computation of stack region end. Add asserts + be more careful about type conversions when computing the stack limit pointer value. R= BUG=none ========== to ========== Overflow-proof the computation of stack region end. Add asserts + be more careful about type conversions when computing the stack limit pointer value. R= BUG=none ==========
LGTM
Description was changed from ========== Overflow-proof the computation of stack region end. Add asserts + be more careful about type conversions when computing the stack limit pointer value. R= BUG=none ========== to ========== Overflow-proof the computation of stack region end. Add asserts + be more careful about type conversions when computing the stack limit pointer value. R=haraken BUG=none ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425243004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425243004/1
Description was changed from ========== Overflow-proof the computation of stack region end. Add asserts + be more careful about type conversions when computing the stack limit pointer value. R=haraken BUG=none ========== to ========== Overflow-proof the computation of stack region end. Add asserts + be more careful about type conversions when computing the stack limit pointer value. R=haraken BUG=none NOTRY=true ==========
The CQ bit was unchecked by sigbjornf@opera.com
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425243004/1
Description was changed from ========== Overflow-proof the computation of stack region end. Add asserts + be more careful about type conversions when computing the stack limit pointer value. R=haraken BUG=none NOTRY=true ========== to ========== Overflow-proof the computation of stack region end. Add asserts + be more careful about type conversions when computing the stack limit pointer value. R=haraken BUG=none ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5ddc71a4449488d1f79405ac05431a7c198d21e0 Cr-Commit-Position: refs/heads/master@{#357569} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
