Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142523005: Web Animations: Define easing for each keyframe (Closed)

Created:
6 years, 10 months ago by Eric Willigers
Modified:
6 years, 10 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Web Animations: Define easing for each keyframe The timing function 'easing' is used by sample() to interpolate between keyframes. See Section 6.16 The Keyframe dictionary in a draft of the Web Animations spec: https://dvcs.w3.org/hg/FXTF/raw-file/rework-animation-model/web-animations/index.html#the-keyframe-dictionary We plan to use easing on keyframes to retire ChainedTimingFunction. BUG=232278 R=shanestephens,dstockwell,timloh Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166803

Patch Set 1 #

Patch Set 2 : Unit tests #

Patch Set 3 : Cubic Bezier test #

Patch Set 4 : Rebase #

Total comments: 6

Patch Set 5 : Rename s_accuracy to accuracyForKeyframeEasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -9 lines) Patch
M Source/core/animation/Animation.cpp View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 1 2 3 4 4 chunks +8 lines, -2 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 1 2 3 4 7 chunks +15 lines, -7 lines 0 comments Download
Source/core/animation/KeyframeEffectModelTest.cpp View 1 2 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Eric Willigers
6 years, 10 months ago (2014-01-30 00:24:33 UTC) #1
Eric Willigers
6 years, 10 months ago (2014-01-31 02:53:55 UTC) #2
Eric Willigers
6 years, 10 months ago (2014-02-06 02:59:51 UTC) #3
Timothy Loh
This seems fine to me. lgtm. https://codereview.chromium.org/142523005/diff/70001/Source/core/animation/KeyframeEffectModel.cpp File Source/core/animation/KeyframeEffectModel.cpp (right): https://codereview.chromium.org/142523005/diff/70001/Source/core/animation/KeyframeEffectModel.cpp#newcode90 Source/core/animation/KeyframeEffectModel.cpp:90: const double s_accuracy ...
6 years, 10 months ago (2014-02-07 04:49:08 UTC) #4
Eric Willigers
https://codereview.chromium.org/142523005/diff/70001/Source/core/animation/KeyframeEffectModel.cpp File Source/core/animation/KeyframeEffectModel.cpp (right): https://codereview.chromium.org/142523005/diff/70001/Source/core/animation/KeyframeEffectModel.cpp#newcode90 Source/core/animation/KeyframeEffectModel.cpp:90: const double s_accuracy = 0.0000001; On 2014/02/07 04:49:09, Timothy ...
6 years, 10 months ago (2014-02-07 05:19:27 UTC) #5
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org
6 years, 10 months ago (2014-02-07 05:19:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/142523005/280001
6 years, 10 months ago (2014-02-07 05:19:50 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 05:39:01 UTC) #8
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=15513
6 years, 10 months ago (2014-02-07 05:39:02 UTC) #9
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org
6 years, 10 months ago (2014-02-09 23:21:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/142523005/280001
6 years, 10 months ago (2014-02-09 23:21:35 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-09 23:45:05 UTC) #12
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=15603
6 years, 10 months ago (2014-02-09 23:45:05 UTC) #13
dstockwell
lgtm
6 years, 10 months ago (2014-02-10 03:49:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/142523005/280001
6 years, 10 months ago (2014-02-10 03:49:23 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 05:51:05 UTC) #16
Message was sent while issue was closed. 
Change committed as 166803

Powered by Google App Engine
This is Rietveld 408576698