Renames gfx::FontList::Derive* family.

chrome/browser/ui/views/location_bar/location_bar_view.cc

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index dc6872531d5b8c437bdd855b373abf1a32a73316..b180c2cbf8ecac9354b4172f7f1f71401a2bd20a 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -264,8 +264,10 @@ void LocationBarView::Init() {
       ResourceBundle::BaseFont);
   const int current_font_size = font_list.GetFontSize();
   const int desired_font_size = browser_defaults::kOmniboxFontPixelSize;
-  if (current_font_size < desired_font_size)
-    font_list = font_list.DeriveFontListWithSize(desired_font_size);

[Alexei Svitkine (slow), 2014/01/20 15:38:10]

Hmm, the left side looks cleaner. Is there a good reason for killing it, rather
than still keeping it as a convenience method?

[Yuki, 2014/01/20 16:43:24]

IMHO, all the fonts should ideally have relative size to the BaseFont in
ui::ResourceBundle.  It's not recommended to specify the absolute size assuming
the default font size would be 14px or so.

In order to discourage specifying the absolute size, I'd like to remove this
method from FontList and Font.

+  if (current_font_size < desired_font_size) {

[msw, 2014/01/21 19:31:12]

nit: this should be !=, to also decrease the font size if needed.

[Yuki, 2014/01/23 15:24:19]

Done.

+    font_list =
+        font_list.DeriveWithSizeDelta(desired_font_size - current_font_size);
+  }
   // Shrink large fonts to make them fit.
   // TODO(pkasting): Stretch the location bar instead in this case.
   const int location_height = GetInternalHeight(true);