Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1425223002: XFA: Restore early return if no FPDF_Page in FORM_DoPageAAction() (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Restore early return if no FPDF_Page in FORM_DoPageAAction() Present in original XFA code drop. BUG=pdfium:259 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/de4791d291b4252045d7922fb838c64d9b711fdf

Patch Set 1 #

Total comments: 4

Patch Set 2 : Test earlier, remove used-only-once local. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M fpdfsdk/src/fpdfformfill.cpp View 1 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Tom Sepez
Lei, last one.
5 years, 1 month ago (2015-10-30 18:41:15 UTC) #3
Lei Zhang
https://codereview.chromium.org/1425223002/diff/1/fpdfsdk/src/fpdfformfill.cpp File fpdfsdk/src/fpdfformfill.cpp (left): https://codereview.chromium.org/1425223002/diff/1/fpdfsdk/src/fpdfformfill.cpp#oldcode666 fpdfsdk/src/fpdfformfill.cpp:666: FX_BOOL bExistOAAction = FALSE; Remember to merge this to ...
5 years, 1 month ago (2015-10-30 18:50:08 UTC) #4
Tom Sepez
https://codereview.chromium.org/1425223002/diff/1/fpdfsdk/src/fpdfformfill.cpp File fpdfsdk/src/fpdfformfill.cpp (right): https://codereview.chromium.org/1425223002/diff/1/fpdfsdk/src/fpdfformfill.cpp#newcode658 fpdfsdk/src/fpdfformfill.cpp:658: CPDFXFA_Page* pPage = (CPDFXFA_Page*)page; On 2015/10/30 18:50:08, Lei Zhang ...
5 years, 1 month ago (2015-10-30 18:58:27 UTC) #5
Tom Sepez
https://codereview.chromium.org/1425223002/diff/1/fpdfsdk/src/fpdfformfill.cpp File fpdfsdk/src/fpdfformfill.cpp (left): https://codereview.chromium.org/1425223002/diff/1/fpdfsdk/src/fpdfformfill.cpp#oldcode666 fpdfsdk/src/fpdfformfill.cpp:666: FX_BOOL bExistOAAction = FALSE; On 2015/10/30 18:50:08, Lei Zhang ...
5 years, 1 month ago (2015-10-30 18:58:42 UTC) #6
Lei Zhang
lgtm
5 years, 1 month ago (2015-10-30 19:12:27 UTC) #7
Tom Sepez
5 years, 1 month ago (2015-10-30 19:13:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
de4791d291b4252045d7922fb838c64d9b711fdf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698