Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1425183003: [turbofan] Move CallBuffer from header to cc file. (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move CallBuffer from header to cc file. Committed: https://crrev.com/19bad2a68c1a40de7db75a85f61ccc74c5e81eb8 Cr-Commit-Position: refs/heads/master@{#31796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -121 lines) Patch
M src/compiler/instruction-selector.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +117 lines, -87 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 1 month ago (2015-10-30 14:19:37 UTC) #2
Benedikt Meurer
Nice. LGTM.
5 years, 1 month ago (2015-10-30 14:20:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425183003/1
5 years, 1 month ago (2015-11-04 14:57:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 15:20:56 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 15:21:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19bad2a68c1a40de7db75a85f61ccc74c5e81eb8
Cr-Commit-Position: refs/heads/master@{#31796}

Powered by Google App Engine
This is Rietveld 408576698