Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: samples/samples.gyp

Issue 1425153006: Fix all relative includes to third_party. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: comments, GN formatting, DEPS roll Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/include/fpdfapi/fpdf_module.h ('K') | « samples/pdfium_test.cc ('k') | testing/embedder_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/samples.gyp
diff --git a/samples/samples.gyp b/samples/samples.gyp
index 35b62b7fcf9905b79a2fa662664c7cac2ec271d5..3dc9a45cae5469076c5bfdb1c1081a3aa7fc5657 100644
--- a/samples/samples.gyp
+++ b/samples/samples.gyp
@@ -13,7 +13,9 @@
'PNG_USE_READ_MACROS',
],
'include_dirs': [
+ # This is implicit in GN.
'<(DEPTH)',
+ '..',
],
'conditions': [
['pdf_enable_v8==1', {
@@ -66,9 +68,6 @@
'../pdfium.gyp:pdfium',
'../third_party/third_party.gyp:pdfium_base',
],
- 'include_dirs': [
- '../../',
- ],
'sources': [
'image_diff.cc',
'image_diff_png.h',
« core/include/fpdfapi/fpdf_module.h ('K') | « samples/pdfium_test.cc ('k') | testing/embedder_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698