Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: pdfium.gyp

Issue 1425153006: Fix all relative includes to third_party. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: comments, GN formatting, DEPS roll Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index 17d4336495110bbf8a1bc08833d5f21f12ae2bd4..05f5a06293aee47e806d59d4bed53ef6728efb2c 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -1,3 +1,7 @@
+# Copyright 2015 PDFium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
{
'variables': {
# TODO(thakis): Enable this, pdfium:29
@@ -20,6 +24,9 @@
'_CRT_SECURE_NO_WARNINGS',
],
'include_dirs': [
+ # This is implicit in GN.
+ '<(DEPTH)',
+ '.',
'third_party/freetype/include',
],
'conditions': [
@@ -326,8 +333,8 @@
'target_name': 'fxcodec',
'type': 'static_library',
'dependencies': [
+ '<(libjpeg_gyp_path):libjpeg',
'third_party/third_party.gyp:fx_lcms2',
- 'third_party/third_party.gyp:fx_libjpeg',
'third_party/third_party.gyp:fx_libopenjpeg',
'third_party/third_party.gyp:fx_zlib',
],
@@ -710,9 +717,6 @@
'pdfium',
'test_support',
],
- 'include_dirs': [
- '<(DEPTH)'
- ],
'sources': [
'core/src/fpdfapi/fpdf_font/fpdf_font_cid_unittest.cpp',
'core/src/fpdfapi/fpdf_font/fpdf_font_unittest.cpp',
@@ -739,9 +743,6 @@
'pdfium',
'test_support',
],
- 'include_dirs': [
- '<(DEPTH)',
- ],
'sources': [
'core/src/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp',
'core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp',
@@ -782,9 +783,6 @@
'<(DEPTH)/testing/gmock.gyp:gmock',
'<(DEPTH)/testing/gtest.gyp:gtest',
],
- 'include_dirs': [
- '<(DEPTH)',
- ],
'sources': [
'testing/fx_string_testhelpers.cpp',
'testing/fx_string_testhelpers.h',

Powered by Google App Engine
This is Rietveld 408576698