Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1425153003: win: Also look in PROGRAMW6432 for cdb (Closed)

Created:
5 years, 1 month ago by scottmg
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Also look in PROGRAMW6432 for cdb This is necessary for 64 bit tools installed on a 64 bit OS, but with the tests run from a 32 bit Python. (sigh) Doesn't happen on bots, but comes up occasionally testing on VMs. R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3e4130ad5d608855e09edf2a9ccdcd130a325293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M snapshot/win/end_to_end_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scottmg
5 years, 1 month ago (2015-10-30 01:01:14 UTC) #2
Mark Mentovai
LGTM Comes up “occasionally.” Makes it sound like there’s an element of chance involved!
5 years, 1 month ago (2015-10-30 01:35:39 UTC) #3
scottmg
On 2015/10/30 01:35:39, Mark Mentovai wrote: > LGTM > > Comes up “occasionally.” Makes it ...
5 years, 1 month ago (2015-10-30 16:16:15 UTC) #4
scottmg
5 years, 1 month ago (2015-11-02 17:35:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e4130ad5d608855e09edf2a9ccdcd130a325293 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698