Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1425143006: Revert of Web Animations: Use a single animation clock (Closed)

Created:
5 years, 1 month ago by Peter Kasting
Modified:
5 years, 1 month ago
Reviewers:
dstockwell, samli
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Web Animations: Use a single animation clock (patchset #7 id:120001 of https://codereview.chromium.org/1410313004/ ) Reason for revert: Still breaks the Android bot (at least): https://build.chromium.org/p/chromium.webkit/waterfall?show=WebKit%20Android%20(Nexus4) Please do not reland without first ensuring you have run the webkit_unit_tests step a few times on an equivalent Android bot. Original issue's description: > Web Animations: Use a single animation clock > > All animation clocks for a page should tick at the same time, but since we > had an animation clock per document there were some cases where clocks > could tick independently. > > This patch moves the clock from Document to PageAnimator. > animation-timeline-detached-no-crash.html is removed as the test was not valid > due to the animation's document not being active. > > Committed: https://crrev.com/b45c39903df3727d21cbc217a0b14c2c85b0715a > Cr-Commit-Position: refs/heads/master@{#356776} > > Committed: https://crrev.com/ddd06a6080e1e7d7d02b15595289940980b04973 > Cr-Commit-Position: refs/heads/master@{#357044} TBR=samli@chromium.org,dstockwell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7e4c010fc4a6ec7672f19ca901e9da1175f0abf0 Cr-Commit-Position: refs/heads/master@{#357050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -127 lines) Patch
A third_party/WebKit/LayoutTests/web-animations-api/animation-timeline-detached-no-crash.html View 1 chunk +14 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/time-consistent-across-frames.html View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStackTest.cpp View 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTest.cpp View 8 chunks +49 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.cpp View 6 chunks +5 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimelineTest.cpp View 11 chunks +46 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorPendingAnimations.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/DocumentAnimations.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
Created Revert of Web Animations: Use a single animation clock
5 years, 1 month ago (2015-10-30 07:45:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425143006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425143006/1
5 years, 1 month ago (2015-10-30 07:46:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 07:47:17 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 07:48:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e4c010fc4a6ec7672f19ca901e9da1175f0abf0
Cr-Commit-Position: refs/heads/master@{#357050}

Powered by Google App Engine
This is Rietveld 408576698