Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1425143004: GN WebView: add resources (Closed)

Created:
5 years, 1 month ago by michaelbai
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN WebView: add resources BUG=532905 Committed: https://crrev.com/ef836d865dbbea4ebbb1c88580c1e35ba30e048d Cr-Commit-Position: refs/heads/master@{#357049}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -0 lines) Patch
M android_webview/BUILD.gn View 1 3 chunks +158 lines, -0 lines 0 comments Download
M android_webview/android_webview.gyp View 5 chunks +5 lines, -0 lines 0 comments Download
A android_webview/webview_repack_locales.gni View 1 chunk +102 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
michaelbai
5 years, 1 month ago (2015-10-30 01:00:31 UTC) #3
Dirk Pranke
lgtm. https://codereview.chromium.org/1425143004/diff/20001/android_webview/webview_repack_locales.gni File android_webview/webview_repack_locales.gni (right): https://codereview.chromium.org/1425143004/diff/20001/android_webview/webview_repack_locales.gni#newcode6 android_webview/webview_repack_locales.gni:6: # modifications to meet WebView's requirement. it is ...
5 years, 1 month ago (2015-10-30 01:48:43 UTC) #4
michaelbai
https://codereview.chromium.org/1425143004/diff/20001/android_webview/webview_repack_locales.gni File android_webview/webview_repack_locales.gni (right): https://codereview.chromium.org/1425143004/diff/20001/android_webview/webview_repack_locales.gni#newcode6 android_webview/webview_repack_locales.gni:6: # modifications to meet WebView's requirement. On 2015/10/30 01:48:43, ...
5 years, 1 month ago (2015-10-30 04:21:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425143004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425143004/20001
5 years, 1 month ago (2015-10-30 04:22:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 05:04:25 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 05:05:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef836d865dbbea4ebbb1c88580c1e35ba30e048d
Cr-Commit-Position: refs/heads/master@{#357049}

Powered by Google App Engine
This is Rietveld 408576698