Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1425143003: VM: Improve and fix double negation on MIPS. (Closed)

Created:
5 years, 1 month ago by Florian Schneider
Modified:
5 years, 1 month ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Improve and fix double negation on MIPS. Add neg-instruction to the MIPS backend and use it instead of mul with -1. Fixes the test that requires that identical(nan, -nan) == false. TEST=language/nan_identical_test R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/64261cbb9da9e41a81d8d4ecdb7681817b71df97

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M runtime/vm/assembler_mips.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/constants_mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/disassembler_mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/language/nan_identical_test.dart View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 1 month ago (2015-10-29 20:27:04 UTC) #2
zra
lgtm https://codereview.chromium.org/1425143003/diff/1/tests/language/nan_identical_test.dart File tests/language/nan_identical_test.dart (right): https://codereview.chromium.org/1425143003/diff/1/tests/language/nan_identical_test.dart#newcode1 tests/language/nan_identical_test.dart:1: // Copyright (c) 2015, the Dart project authors. ...
5 years, 1 month ago (2015-10-29 21:16:14 UTC) #3
Florian Schneider
5 years, 1 month ago (2015-10-29 21:34:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
64261cbb9da9e41a81d8d4ecdb7681817b71df97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698