Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: src/heap/heap.cc

Issue 1425143002: Remove the remaining parts of background idle notification. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index e29c4c9df24fc71653834efe2ca6fe3b2e8359c4..49b1e0330b932fd056f2cab72e3590941f6c4176 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -4210,18 +4210,6 @@ void Heap::IdleNotificationEpilogue(GCIdleTimeAction action,
}
-void Heap::CheckBackgroundIdleNotification(double idle_time_in_ms,
- double now_ms) {
- // TODO(ulan): Remove this function once Chrome uses new API
- // for foreground/background notification.
- if (idle_time_in_ms >= GCIdleTimeHandler::kMinBackgroundIdleTime) {
- optimize_for_memory_usage_ = true;
- } else {
- optimize_for_memory_usage_ = false;
- }
-}
-
-
double Heap::MonotonicallyIncreasingTimeInMs() {
return V8::GetCurrentPlatform()->MonotonicallyIncreasingTime() *
static_cast<double>(base::Time::kMillisecondsPerSecond);
@@ -4246,8 +4234,6 @@ bool Heap::IdleNotification(double deadline_in_seconds) {
double start_ms = MonotonicallyIncreasingTimeInMs();
double idle_time_in_ms = deadline_in_ms - start_ms;
- CheckBackgroundIdleNotification(idle_time_in_ms, start_ms);
-
tracer()->SampleAllocation(start_ms, NewSpaceAllocationCounter(),
OldGenerationAllocationCounter());
« no previous file with comments | « src/heap/heap.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698