Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issue 1425123002: Makes event dispatch implicitly target specific window until release (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes event dispatch implicitly target specific window until release We were doing this before for mouse events, but not touch events. Now the two have the same logic. Also makes event dispatch deal correctly with window being destroyed/visibility-changing or hiearchy changing during dispatch. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/5c7cb81a4182a6c3166aead6e529ec28a3d817f9 Cr-Commit-Position: refs/heads/master@{#356846}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : rename and compile failures #

Patch Set 4 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -66 lines) Patch
M components/mus/ws/event_dispatcher.h View 1 2 3 3 chunks +49 lines, -10 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 1 2 3 5 chunks +120 lines, -56 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 1 2 3 3 chunks +159 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sky
5 years, 1 month ago (2015-10-29 00:12:16 UTC) #1
Ben Goodger (Google)
5 years, 1 month ago (2015-10-29 00:34:16 UTC) #3
sadrul
lgtm https://codereview.chromium.org/1425123002/diff/20001/components/mus/ws/event_dispatcher.cc File components/mus/ws/event_dispatcher.cc (right): https://codereview.chromium.org/1425123002/diff/20001/components/mus/ws/event_dispatcher.cc#newcode286 components/mus/ws/event_dispatcher.cc:286: bool EventDispatcher::IsSendingPointerEventsToTarget(ServerWindow* window) { Would IsObservingWindow() better explain ...
5 years, 1 month ago (2015-10-29 00:48:25 UTC) #4
sky
https://codereview.chromium.org/1425123002/diff/20001/components/mus/ws/event_dispatcher.cc File components/mus/ws/event_dispatcher.cc (right): https://codereview.chromium.org/1425123002/diff/20001/components/mus/ws/event_dispatcher.cc#newcode286 components/mus/ws/event_dispatcher.cc:286: bool EventDispatcher::IsSendingPointerEventsToTarget(ServerWindow* window) { On 2015/10/29 00:48:25, sadrul wrote: ...
5 years, 1 month ago (2015-10-29 14:54:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425123002/60001
5 years, 1 month ago (2015-10-29 15:05:01 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-29 15:19:30 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 15:20:56 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5c7cb81a4182a6c3166aead6e529ec28a3d817f9
Cr-Commit-Position: refs/heads/master@{#356846}

Powered by Google App Engine
This is Rietveld 408576698