media: Register MojoMediaApplication to run in Utility process.

media: Register MojoMediaApplication to run in Utility process.

The registration was lost during refactoring how OOP apps are registered in
MojoShellContext.

BUG=403462
TEST=GN build with 'enable_mojo_media = "utility"' works with HTML5 audio.

Committed: https://crrev.com/5e63046722cd53acd993a32eae2789d6315a8111
Cr-Commit-Position: refs/heads/master@{#357037}

[xhwang, 2015-10-29 20:40:20]

xhwang@chromium.org changed reviewers:
+ rockot@chromium.org

[xhwang, 2015-10-29 20:40:20]

PTAL

https://chromiumcodereview.appspot.com/1425113003/diff/1/chromecast/browser/c...
File chromecast/browser/cast_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1425113003/diff/1/chromecast/browser/c...
chromecast/browser/cast_content_browser_client.cc:362: base::UTF8ToUTF16("Media
App")));
This is a user facing string and I felt "Media Renderer" isn't really user
friendly. Maybe "Media App" is still a bit odd since users don't know what an
"App" is. Is there any recommendation here? Maybe something like "Media
Service", or "Media Process"?

[Ken Rockot(use gerrit already), 2015-10-29 20:44:06]

lgtm

https://chromiumcodereview.appspot.com/1425113003/diff/1/chromecast/browser/c...
File chromecast/browser/cast_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1425113003/diff/1/chromecast/browser/c...
chromecast/browser/cast_content_browser_client.cc:362: base::UTF8ToUTF16("Media
App")));
On 2015/10/29 20:40:20, xhwang wrote:
> This is a user facing string and I felt "Media Renderer" isn't really user
> friendly. Maybe "Media App" is still a bit odd since users don't know what an
> "App" is. Is there any recommendation here? Maybe something like "Media
> Service", or "Media Process"?

I'm not sure anything is going to be user friendly here. I kinda like "Media
Renderer" because it's accurate and more precise than "Media App". No strong
opinion though.

[xhwang, 2015-10-29 20:50:02]

https://chromiumcodereview.appspot.com/1425113003/diff/1/chromecast/browser/c...
File chromecast/browser/cast_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1425113003/diff/1/chromecast/browser/c...
chromecast/browser/cast_content_browser_client.cc:362: base::UTF8ToUTF16("Media
App")));
On 2015/10/29 20:44:06, Ken Rockot wrote:
> On 2015/10/29 20:40:20, xhwang wrote:
> > This is a user facing string and I felt "Media Renderer" isn't really user
> > friendly. Maybe "Media App" is still a bit odd since users don't know what
an
> > "App" is. Is there any recommendation here? Maybe something like "Media
> > Service", or "Media Process"?
> 
> I'm not sure anything is going to be user friendly here. I kinda like "Media
> Renderer" because it's accurate and more precise than "Media App". No strong
> opinion though.

Media Renderer is only one service provided by the app. The app could also
provide CDM service. In many cases, we only need the CDM service. In that case,
"Media Renderer" would be wrong.

[Ken Rockot(use gerrit already), 2015-10-29 20:51:17]

On 2015/10/29 20:50:02, xhwang wrote:
>
https://chromiumcodereview.appspot.com/1425113003/diff/1/chromecast/browser/c...
> File chromecast/browser/cast_content_browser_client.cc (right):
> 
>
https://chromiumcodereview.appspot.com/1425113003/diff/1/chromecast/browser/c...
> chromecast/browser/cast_content_browser_client.cc:362:
base::UTF8ToUTF16("Media
> App")));
> On 2015/10/29 20:44:06, Ken Rockot wrote:
> > On 2015/10/29 20:40:20, xhwang wrote:
> > > This is a user facing string and I felt "Media Renderer" isn't really user
> > > friendly. Maybe "Media App" is still a bit odd since users don't know what
> an
> > > "App" is. Is there any recommendation here? Maybe something like "Media
> > > Service", or "Media Process"?
> > 
> > I'm not sure anything is going to be user friendly here. I kinda like "Media
> > Renderer" because it's accurate and more precise than "Media App". No strong
> > opinion though.
> 
> Media Renderer is only one service provided by the app. The app could also
> provide CDM service. In many cases, we only need the CDM service. In that
case,
> "Media Renderer" would be wrong.

Ah OK. Got it. Media app sgtm

[xhwang, 2015-10-29 21:08:14]

xhwang@chromium.org changed reviewers:
+ halliwell@chromium.org, thestig@chromium.org

[xhwang, 2015-10-29 21:08:15]

This is a small change and should be pretty straightforward to review.

thestig: Please OWNERS review chrome/browser/BUILD.gn
halliwell: Please OWNERS review chromecast/

[Lei Zhang, 2015-10-29 21:23:52]

https://chromiumcodereview.appspot.com/1425113003/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1425113003/diff/1/chrome/browser/BUILD...
chrome/browser/BUILD.gn:889: if (enable_mojo_media != "none") {
No equivalent GYP change?

[xhwang, 2015-10-29 21:25:48]

https://chromiumcodereview.appspot.com/1425113003/diff/1/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://chromiumcodereview.appspot.com/1425113003/diff/1/chrome/browser/BUILD...
chrome/browser/BUILD.gn:889: if (enable_mojo_media != "none") {
On 2015/10/29 21:23:52, Lei Zhang wrote:
> No equivalent GYP change?

Good question. The MojoMediaApplication currently only supports gn build.

[Lei Zhang, 2015-10-29 21:45:31]

Ah, I see how this works for GN only - via the #define. LGTM with some nits.

https://chromiumcodereview.appspot.com/1425113003/diff/20001/chrome/browser/c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1425113003/diff/20001/chrome/browser/c...
chrome/browser/chrome_content_browser_client.cc:2595: base::UTF8ToUTF16("Media
App")));
ASCIIToUTF16

https://chromiumcodereview.appspot.com/1425113003/diff/20001/chromecast/brows...
File chromecast/browser/cast_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1425113003/diff/20001/chromecast/brows...
chromecast/browser/cast_content_browser_client.cc:362: base::UTF8ToUTF16("Media
App")));
ditto

[xhwang, 2015-10-29 22:34:49]

comments addressed

[xhwang, 2015-10-29 22:35:00]

https://chromiumcodereview.appspot.com/1425113003/diff/20001/chrome/browser/c...
File chrome/browser/chrome_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1425113003/diff/20001/chrome/browser/c...
chrome/browser/chrome_content_browser_client.cc:2595: base::UTF8ToUTF16("Media
App")));
On 2015/10/29 21:45:31, Lei Zhang wrote:
> ASCIIToUTF16

Done.

https://chromiumcodereview.appspot.com/1425113003/diff/20001/chromecast/brows...
File chromecast/browser/cast_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/1425113003/diff/20001/chromecast/brows...
chromecast/browser/cast_content_browser_client.cc:362: base::UTF8ToUTF16("Media
App")));
On 2015/10/29 21:45:31, Lei Zhang wrote:
> ditto

Done.

[halliwell, 2015-10-30 01:26:20]

On 2015/10/29 22:35:00, xhwang wrote:
>
https://chromiumcodereview.appspot.com/1425113003/diff/20001/chrome/browser/c...
> File chrome/browser/chrome_content_browser_client.cc (right):
> 
>
https://chromiumcodereview.appspot.com/1425113003/diff/20001/chrome/browser/c...
> chrome/browser/chrome_content_browser_client.cc:2595: base::UTF8ToUTF16("Media
> App")));
> On 2015/10/29 21:45:31, Lei Zhang wrote:
> > ASCIIToUTF16
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/1425113003/diff/20001/chromecast/brows...
> File chromecast/browser/cast_content_browser_client.cc (right):
> 
>
https://chromiumcodereview.appspot.com/1425113003/diff/20001/chromecast/brows...
> chromecast/browser/cast_content_browser_client.cc:362:
base::UTF8ToUTF16("Media
> App")));
> On 2015/10/29 21:45:31, Lei Zhang wrote:
> > ditto
> 
> Done.

chromecast/ lgtm

[xhwang, 2015-10-30 03:13:07]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2015-10-30 03:13:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
thestig@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1425113003/#ps40001
(title: "comments addressed")

[commit-bot: I haz the power, 2015-10-30 03:13:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425113003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425113003/40001

[commit-bot: I haz the power, 2015-10-30 03:18:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-30 03:19:35]

Patchset 3 (id:??) landed as
https://crrev.com/5e63046722cd53acd993a32eae2789d6315a8111
Cr-Commit-Position: refs/heads/master@{#357037}