Merge (x & y) == 0 pattern to emit a single test instruction.

runtime/vm/intermediate_language.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 486 matching lines @@
   M(BoxInteger)                                                                \
   M(BinaryMintOp)                                                              \
   M(ShiftMintOp)                                                               \
   M(UnaryMintOp)                                                               \
   M(CheckArrayBound)                                                           \
   M(Constraint)                                                                \
   M(StringFromCharCode)                                                        \
   M(InvokeMathCFunction)                                                       \
   M(GuardField)                                                                \
   M(IfThenElse)                                                                \
+  M(TestSmi)                                                                   \
 
 #define FORWARD_DECLARATION(type) class type##Instr;
 FOR_EACH_INSTRUCTION(FORWARD_DECLARATION)
 #undef FORWARD_DECLARATION
 
 
 // Functions required in all concrete instruction classes.
 #define DECLARE_INSTRUCTION(type)                                              \
   virtual Tag tag() const { return k##type; }                                  \
   virtual void Accept(FlowGraphVisitor* visitor);                              \
@@ skipping 1962 matching lines @@
 
   Token::Kind kind() const { return kind_; }
 
   virtual void EmitBranchCode(FlowGraphCompiler* compiler,
                               BranchInstr* branch) = 0;
 
   void SetDeoptId(intptr_t deopt_id) {
     deopt_id_ = deopt_id;
   }
 
+  virtual bool IsSmiEquality() const {
+    return false;
+  }
+
  protected:
   Token::Kind kind_;
 };
 
 
 // Inlined functions from class BranchInstr that forward to their comparison.
 inline intptr_t BranchInstr::ArgumentCount() const {
   return comparison()->ArgumentCount();
 }
 
@@ skipping 79 matching lines @@
 
  private:
   // True if the comparison must check for double, Mint or Bigint and
   // use value comparison instead.
   bool needs_number_check_;
 
   DISALLOW_COPY_AND_ASSIGN(StrictCompareInstr);
 };
 
 
+class TestSmiInstr : public ComparisonInstr {

[srdjan, 2013/04/15 20:27:27]

Maybe add comment what this instruction is for.

[Vyacheslav Egorov (Google), 2013/04/16 11:51:16]

Done.

+ public:
+  TestSmiInstr(Token::Kind kind, Value* left, Value* right)
+      : ComparisonInstr(kind, left, right) {
+  }
+
+  DECLARE_INSTRUCTION(TestSmi);
+
+  virtual CompileType ComputeType() const {
+    return CompileType::Bool();
+  }
+
+  virtual bool CanDeoptimize() const {
+    return false;
+  }
+
+  virtual bool HasSideEffect() const {
+    return false;
+  }
+
+  virtual void EmitBranchCode(FlowGraphCompiler* compiler,
+                              BranchInstr* branch);
+
+  virtual Representation RequiredInputRepresentation(intptr_t idx) const {
+    return kTagged;
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TestSmiInstr);
+};
+
+
 class EqualityCompareInstr : public ComparisonInstr {
  public:
   EqualityCompareInstr(intptr_t token_pos,
                        Token::Kind kind,
                        Value* left,
                        Value* right)
       : ComparisonInstr(kind, left, right),
         token_pos_(token_pos),
         receiver_class_id_(kIllegalCid) {
     // deopt_id() checks receiver_class_id_ value.
     ic_data_ = Isolate::Current()->GetICDataForDeoptId(deopt_id());
-    ASSERT((kind == Token::kEQ) || (kind == Token::kNE));
+    ASSERT((kind == Token::kEQ) ||
+           (kind == Token::kNE));

[srdjan, 2013/04/15 20:27:27]

Back to one line?

[Vyacheslav Egorov (Google), 2013/04/16 11:51:16]

Done.

   }
 
   DECLARE_INSTRUCTION(EqualityCompare)
   virtual CompileType ComputeType() const;
   virtual bool RecomputeType();
 
   const ICData* ic_data() const { return ic_data_; }
   bool HasICData() const {
     return (ic_data() != NULL) && !ic_data()->IsNull();
   }
@@ skipping 30 matching lines @@
 
   virtual Representation RequiredInputRepresentation(intptr_t idx) const {
     ASSERT((idx == 0) || (idx == 1));
     if (receiver_class_id() == kDoubleCid) return kUnboxedDouble;
     if (receiver_class_id() == kMintCid) return kUnboxedMint;
     return kTagged;
   }
 
   bool IsPolymorphic() const;
 
+  virtual bool IsSmiEquality() const {
+    return receiver_class_id() == kSmiCid;
+  }
+
  private:
   const ICData* ic_data_;
   const intptr_t token_pos_;
   intptr_t receiver_class_id_;  // Set by optimizer.
 
   DISALLOW_COPY_AND_ASSIGN(EqualityCompareInstr);
 };
 
 
 class RelationalOpInstr : public ComparisonInstr {
@@ skipping 2224 matching lines @@
   ForwardInstructionIterator* current_iterator_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_