Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 14251022: Allow multiple exits from LaunchUpdateCommand() for safety and clarity. (Closed)

Created:
7 years, 8 months ago by Peter Kasting
Modified:
7 years, 8 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Allow multiple exits from LaunchUpdateCommand() for safety and clarity. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194370

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -25 lines) Patch
M chrome_frame/update_launcher.cc View 1 2 chunks +12 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
7 years, 8 months ago (2013-04-15 19:55:58 UTC) #1
grt (UTC plus 2)
https://codereview.chromium.org/14251022/diff/1/chrome_frame/update_launcher.cc File chrome_frame/update_launcher.cc (right): https://codereview.chromium.org/14251022/diff/1/chrome_frame/update_launcher.cc#newcode62 chrome_frame/update_launcher.cc:62: ULONG_PTR phandle = NULL; can this be a base::win::ScopedHandle, ...
7 years, 8 months ago (2013-04-15 23:32:54 UTC) #2
Peter Kasting
https://codereview.chromium.org/14251022/diff/1/chrome_frame/update_launcher.cc File chrome_frame/update_launcher.cc (right): https://codereview.chromium.org/14251022/diff/1/chrome_frame/update_launcher.cc#newcode62 chrome_frame/update_launcher.cc:62: ULONG_PTR phandle = NULL; On 2013/04/15 23:32:54, grt wrote: ...
7 years, 8 months ago (2013-04-16 00:09:22 UTC) #3
grt (UTC plus 2)
lgtm
7 years, 8 months ago (2013-04-16 13:24:30 UTC) #4
Peter Kasting
7 years, 8 months ago (2013-04-16 16:43:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r194370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698