tools/testing/dart/test_progress.dart - Issue 14251009: Only print the failure summary header if there were failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_progress.dart

Issue 14251009: Only print the failure summary header if there were failures (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_progress.dart

diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart

index 5eac74a9c3dcea5095c2719d98a053d5e4e113e7..659fef5bae43a20c89975686430a8b78801b7a71 100644

--- a/tools/testing/dart/test_progress.dart

+++ b/tools/testing/dart/test_progress.dart

@@ -344,8 +344,8 @@ class TestFailurePrinter extends EventListener {

void allDone() {

if (_printSummary) {

- print('\n=== Failure summary:\n');

if (!_failureSummary.isEmpty) {

+ print('\n=== Failure summary:\n');

for (String line in _failureSummary) {

print(line);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »