Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: utils/tests/pub/error_group_test.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebuild DOM and rebase. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/async/stream_impl.dart ('K') | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/error_group_test.dart
diff --git a/utils/tests/pub/error_group_test.dart b/utils/tests/pub/error_group_test.dart
index e7aa477e4d9d3eb00cacdd71bb7c98434e6a0e2d..cd9b1936e234f0372d7141ab2d4e96724919f7db 100644
--- a/utils/tests/pub/error_group_test.dart
+++ b/utils/tests/pub/error_group_test.dart
@@ -28,13 +28,13 @@ main() {
test('should pass signaled errors to .done', () {
expect(errorGroup.done, throwsFormatException);
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
});
test("shouldn't allow additional futures or streams once an error has been "
"signaled", () {
expect(errorGroup.done, throwsFormatException);
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
expect(() => errorGroup.registerFuture(new Future.immediate(null)),
throwsStateError);
@@ -87,7 +87,7 @@ main() {
'and should ignore a subsequent value from that future', () {
expect(future, throwsFormatException);
// errorGroup shouldn't top-level the exception
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
completer.complete('value');
});
@@ -95,7 +95,7 @@ main() {
'and should ignore a subsequent exception from that future', () {
expect(future, throwsFormatException);
// errorGroup shouldn't top-level the exception
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
completer.completeError(new ArgumentError());
});
@@ -103,7 +103,7 @@ main() {
'future has a listener', () {
expect(future, throwsFormatException);
expect(errorGroup.done, throwsFormatException);
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
});
test("should complete .done if the future receives a value even if the "
@@ -131,7 +131,7 @@ main() {
"a listener",
() {
expect(errorGroup.done, throwsFormatException);
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
// A listener added afterwards should receive the exception
expect(errorGroup.done.catchError((_) {
@@ -192,7 +192,7 @@ main() {
expect(future1.then((_) {
// shouldn't cause a top-level exception
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
}), completes);
});
});
@@ -219,21 +219,21 @@ main() {
'listener', () {
expect(stream.first, throwsFormatException);
// errorGroup shouldn't top-level the exception
- controller.addError(new AsyncError(new FormatException()));
+ controller.addError(new FormatException());
});
test('should notify the error group of an exception from the stream even '
'if it has a listener', () {
expect(stream.first, throwsFormatException);
expect(errorGroup.done, throwsFormatException);
- controller.addError(new AsyncError(new FormatException()));
+ controller.addError(new FormatException());
});
test('should pass a signaled exception to the stream if it has a listener '
'and should unsubscribe that stream', () {
expect(stream.first, throwsFormatException);
// errorGroup shouldn't top-level the exception
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
expect(stream.first.catchError((_) {
controller.add('value');
@@ -245,7 +245,7 @@ main() {
'stream has a listener', () {
expect(stream.first, throwsFormatException);
expect(errorGroup.done, throwsFormatException);
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
});
test("should complete .done when the stream is done even if the stream "
@@ -263,7 +263,7 @@ main() {
test("should pipe an exception from the stream to .done if the stream "
"doesn't have a listener", () {
expect(errorGroup.done, throwsFormatException);
- controller.addError(new AsyncError(new FormatException()));
+ controller.addError(new FormatException());
// A listener added afterwards should see an empty stream, since it's not
// single-subscription
@@ -277,7 +277,7 @@ main() {
"have a listener",
() {
expect(errorGroup.done, throwsFormatException);
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
// A listener added afterwards should receive the exception
expect(errorGroup.done.catchError((_) {
@@ -311,7 +311,7 @@ main() {
test("should pipe an exception from the stream to .done if the stream "
"doesn't have a listener", () {
expect(errorGroup.done, throwsFormatException);
- controller.addError(new AsyncError(new FormatException()));
+ controller.addError(new FormatException());
// A listener added afterwards should receive the exception
expect(errorGroup.done.catchError((_) {
@@ -324,7 +324,7 @@ main() {
"have a listener",
() {
expect(errorGroup.done, throwsFormatException);
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
// A listener added afterwards should receive the exception
expect(errorGroup.done.catchError((_) {
@@ -354,7 +354,7 @@ main() {
expect(stream2.first, throwsFormatException);
expect(errorGroup.done, throwsFormatException);
- controller1.addError(new AsyncError(new FormatException()));
+ controller1.addError(new FormatException());
});
test("each future should be able to emit values independently", () {
@@ -373,7 +373,7 @@ main() {
expect(stream1.toList().then((_) {
// shouldn't cause a top-level exception
- controller2.addError(new AsyncError(new FormatException()));
+ controller2.addError(new FormatException());
}), completes);
});
@@ -384,7 +384,7 @@ main() {
expect(stream1.toList().then((_) {
// shouldn't cause a top-level exception
- errorGroup.signalError(new AsyncError(new FormatException()));
+ errorGroup.signalError(new FormatException());
}), completes);
});
});
@@ -408,7 +408,7 @@ main() {
expect(future, throwsFormatException);
expect(errorGroup.done, throwsFormatException);
- controller.addError(new AsyncError(new FormatException()));
+ controller.addError(new FormatException());
});
test("should pipe exceptions from the future to the stream", () {
@@ -436,7 +436,7 @@ main() {
expect(future.then((_) {
// shouldn't cause a top-level exception
- controller.addError(new AsyncError(new FormatException()));
+ controller.addError(new FormatException());
}), completes);
});
« sdk/lib/async/stream_impl.dart ('K') | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698