Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: sdk/lib/mirrors/mirrors.dart

Issue 14251005: Change url to uri on LibraryMirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/mirrors/mirrors.dart
diff --git a/sdk/lib/mirrors/mirrors.dart b/sdk/lib/mirrors/mirrors.dart
index b5b971aaafbe98343ca1f1cab4686aac4e95af0b..4d5e000e7097c294ae0ab1ed61196a8f3136a242 100644
--- a/sdk/lib/mirrors/mirrors.dart
+++ b/sdk/lib/mirrors/mirrors.dart
@@ -16,6 +16,7 @@ library dart.mirrors;
import 'dart:async';
import 'dart:isolate';
+import 'dart:uri';
/**
* A [MirrorSystem] is the main interface used to reflect on a set of
@@ -282,13 +283,9 @@ abstract class ClosureMirror implements InstanceMirror {
*/
abstract class LibraryMirror implements DeclarationMirror, ObjectMirror {
/**
- * The url of the library.
- *
- * TODO(turnidge): Document where this url comes from. Will this
- * value be sensible?
+ * The absolute uri of the library.
*/
- // TODO(ahe): Change type to [Uri], rename to "uri"?
- String get url;
+ Uri get uri;
/**
* An immutable map from from names to mirrors for all members in

Powered by Google App Engine
This is Rietveld 408576698