Remove Lua from the Google3 build.

Remove Lua from the Google3 build.

See internal cl/107087297 for details.

Rename some variables in BUILD/BUILD.public.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/39e7aa48d7ca4c144c457374bf0a0dcc0c5be92d

[dogben, 2015-11-05 16:22:31]

benjaminwagner@google.com changed reviewers:
+ mtklein@google.com

[dogben, 2015-11-05 17:37:26]

On 2015/11/05 at 16:22:31, Ben Wagner wrote:
> 

Hang on, I also need to remove dependency on Lua. I will post a new patch when
done.

[dogben, 2015-11-05 20:13:38]

Description was changed from

==========
In Google3 BUILD file, remove dependency on GL.

See internal cl/107087297 for details.

BUG=skia:
==========

to

==========
Add a ":skia_base" target to Google3 BUILD file, which does not depend on GL or
Lua. Add dependent libraries for GL and "util" portions of Skia. The ":skia"
target still contains everything it did before.

See internal cl/107087297 for details.

BUG=skia:
==========

[dogben, 2015-11-05 20:29:13]

On 2015/11/05 at 17:37:26, Ben Wagner wrote:
> On 2015/11/05 at 16:22:31, Ben Wagner wrote:
> > 
> 
> Hang on, I also need to remove dependency on Lua. I will post a new patch when
done.

Ok, PTAL.

[mtklein, 2015-11-05 20:37:17]

https://codereview.chromium.org/1425013008/diff/20001/BUILD.public
File BUILD.public (right):

https://codereview.chromium.org/1425013008/diff/20001/BUILD.public#newcode284
BUILD.public:284: GL_SRCS_IOS = glob(
Is there some tool that yells at us if we write these more compactly?

GL_SRCS_IOS = [ "src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp" ]
GL_HDRS = glob([ "include/gpu/gl/**/*.h" ])

?

https://codereview.chromium.org/1425013008/diff/20001/BUILD.public#newcode530
BUILD.public:530: cc_library(
Let's leave out Lua entirely.  It's way less important a feature than even these
few lines to support it justify.

Alternatively, can we depend on the Lua the other folks depend on?

[dogben, 2015-11-06 00:14:54]

Description was changed from

==========
Add a ":skia_base" target to Google3 BUILD file, which does not depend on GL or
Lua. Add dependent libraries for GL and "util" portions of Skia. The ":skia"
target still contains everything it did before.

See internal cl/107087297 for details.

BUG=skia:
==========

to

==========
Add a ":skia_base" target to Google3 BUILD file, which does not depend on GL.
Add dependent libraries for GL portion of Skia. The ":skia" target includes both
:skia_base and :skia_gl.

Remove Lua from the Google3 build.

See internal cl/107087297 for details.

BUG=skia:
==========

[dogben, 2015-11-06 00:18:18]

PTAL

https://codereview.chromium.org/1425013008/diff/20001/BUILD.public
File BUILD.public (right):

https://codereview.chromium.org/1425013008/diff/20001/BUILD.public#newcode284
BUILD.public:284: GL_SRCS_IOS = glob(
On 2015/11/05 at 20:37:17, mtklein wrote:
> Is there some tool that yells at us if we write these more compactly?
> 
> GL_SRCS_IOS = [ "src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp" ]
> GL_HDRS = glob([ "include/gpu/gl/**/*.h" ])
> 
> ?

Done.

https://codereview.chromium.org/1425013008/diff/20001/BUILD.public#newcode530
BUILD.public:530: cc_library(
On 2015/11/05 at 20:37:17, mtklein wrote:
> Let's leave out Lua entirely.  It's way less important a feature than even
these few lines to support it justify.
> 
> Alternatively, can we depend on the Lua the other folks depend on?

No. See internal CL description.

[dogben, 2015-11-13 18:36:09]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 18:36:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425013008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425013008/60001

[dogben, 2015-11-13 18:37:17]

Description was changed from

==========
Add a ":skia_base" target to Google3 BUILD file, which does not depend on GL.
Add dependent libraries for GL portion of Skia. The ":skia" target includes both
:skia_base and :skia_gl.

Remove Lua from the Google3 build.

See internal cl/107087297 for details.

BUG=skia:
==========

to

==========
Remove Lua from the Google3 build.

See internal cl/107087297 for details.

Rename some variables in BUILD/BUILD.public.

BUG=skia:
==========

[commit-bot: I haz the power, 2015-11-13 18:47:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 18:47:45]

Dry run: This issue passed the CQ dry run.

[dogben, 2015-11-13 19:10:16]

GL issue has been addressed in cl/107692108. I kept the renames because I think
it makes things clearer.

[mtklein, 2015-11-18 20:57:53]

lgtm

[dogben, 2015-11-18 21:13:49]

The CQ bit was checked by benjaminwagner@google.com

[commit-bot: I haz the power, 2015-11-18 21:13:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425013008/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425013008/80001

[commit-bot: I haz the power, 2015-11-18 21:26:12]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/39e7aa48d7ca4c144c457374bf0a0dcc0c5be92d