Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: test/cctest/test-global-handles.cc

Issue 1425013006: Using override keyword in ObjectVisitor class hierarchy. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/snapshot/serialize.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 virtual const char* GetLabel() { return "whatever"; } 69 virtual const char* GetLabel() { return "whatever"; }
70 70
71 private: 71 private:
72 bool has_been_disposed_; 72 bool has_been_disposed_;
73 }; 73 };
74 74
75 75
76 class TestObjectVisitor : public ObjectVisitor { 76 class TestObjectVisitor : public ObjectVisitor {
77 public: 77 public:
78 virtual void VisitPointers(Object** start, Object** end) { 78 void VisitPointers(Object** start, Object** end) override {
79 for (Object** o = start; o != end; ++o) 79 for (Object** o = start; o != end; ++o)
80 visited.Add(*o); 80 visited.Add(*o);
81 } 81 }
82 82
83 List<Object*> visited; 83 List<Object*> visited;
84 }; 84 };
85 85
86 86
87 TEST(IterateObjectGroupsOldApi) { 87 TEST(IterateObjectGroupsOldApi) {
88 CcTest::InitializeVM(); 88 CcTest::InitializeVM();
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 v8::Local<v8::Object> o = v8::Object::New(isolate); 390 v8::Local<v8::Object> o = v8::Object::New(isolate);
391 CHECK(!o.IsEmpty()); 391 CHECK(!o.IsEmpty());
392 v8::Persistent<v8::Object> p(isolate, o); 392 v8::Persistent<v8::Object> p(isolate, o);
393 CHECK(o == p.Get(isolate)); 393 CHECK(o == p.Get(isolate));
394 CHECK(v8::Local<v8::Object>::New(isolate, p) == p.Get(isolate)); 394 CHECK(v8::Local<v8::Object>::New(isolate, p) == p.Get(isolate));
395 395
396 v8::Global<v8::Object> g(isolate, o); 396 v8::Global<v8::Object> g(isolate, o);
397 CHECK(o == g.Get(isolate)); 397 CHECK(o == g.Get(isolate));
398 CHECK(v8::Local<v8::Object>::New(isolate, g) == g.Get(isolate)); 398 CHECK(v8::Local<v8::Object>::New(isolate, g) == g.Get(isolate));
399 } 399 }
OLDNEW
« no previous file with comments | « src/snapshot/serialize.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698