Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: content/browser/download/save_package.cc

Issue 1425013004: Single referrer for all savable resources from a given frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing... Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/save_package.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_package.cc
diff --git a/content/browser/download/save_package.cc b/content/browser/download/save_package.cc
index 84ccc598767b34e7b4030a9a014e727b7969fa45..d335e50da08ce6f99f7c05212f0b71bef76abdfa 100644
--- a/content/browser/download/save_package.cc
+++ b/content/browser/download/save_package.cc
@@ -1182,16 +1182,12 @@ void SavePackage::OnSavableResourceLinksResponse(
RenderFrameHost* sender,
const GURL& frame_url,
const std::vector<GURL>& resources_list,
- const std::vector<Referrer>& referrers_list) {
+ const Referrer& referrer) {
if (wait_state_ != RESOURCES_LIST)
return;
- if (resources_list.size() != referrers_list.size())
- return;
-
// Add all sub-resources to wait list.
- for (int i = 0; i < static_cast<int>(resources_list.size()); ++i) {
- const GURL& u = resources_list[i];
+ for (const GURL& u : resources_list) {
if (!u.is_valid())
continue;
if (unique_urls_to_save_.count(u))
@@ -1201,7 +1197,7 @@ void SavePackage::OnSavableResourceLinksResponse(
SaveFileCreateInfo::SaveFileSource save_source =
u.SchemeIsFile() ? SaveFileCreateInfo::SAVE_FILE_FROM_FILE
: SaveFileCreateInfo::SAVE_FILE_FROM_NET;
- SaveItem* save_item = new SaveItem(u, referrers_list[i], this, save_source);
+ SaveItem* save_item = new SaveItem(u, referrer, this, save_source);
waiting_item_queue_.push(save_item);
}
« no previous file with comments | « content/browser/download/save_package.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698