Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2236)

Unified Diff: chrome/browser/metrics/thread_watcher.cc

Issue 14250003: ThreadWatcher - give ShutdownWatchDogThread::Alarm a more unique function body. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/thread_watcher.cc
===================================================================
--- chrome/browser/metrics/thread_watcher.cc (revision 192196)
+++ chrome/browser/metrics/thread_watcher.cc (working copy)
@@ -51,6 +51,10 @@
#endif
}
+NOINLINE void ShutdownCrash() {
+ NullPointerCrash(__LINE__);
+}
+
NOINLINE void ThreadUnresponsive_UI() {
NullPointerCrash(__LINE__);
}
@@ -873,7 +877,7 @@
// Alarm is called if the time expires after an Arm() without someone calling
// Disarm(). We crash the browser if this method is called.
virtual void Alarm() OVERRIDE {
- CHECK(false);
+ ShutdownCrash();
}
DISALLOW_COPY_AND_ASSIGN(ShutdownWatchDogThread);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698