Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2384)

Unified Diff: build/android/gyp/copy_ex.py

Issue 1424983004: Using copy_ex to copy assets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: using copy_ex Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/java/src/org/chromium/base/ApkAssets.java ('k') | chromecast/chromecast.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/copy_ex.py
diff --git a/build/android/gyp/copy_ex.py b/build/android/gyp/copy_ex.py
index 3d7434df6e69a32501c6ec251526434fdefa1401..98eddfb4c95f1e9286278194b946d02c187c12bf 100755
--- a/build/android/gyp/copy_ex.py
+++ b/build/android/gyp/copy_ex.py
@@ -32,6 +32,8 @@ def CopyFile(f, dest, deps):
else:
shutil.copy(f, dest)
deps.append(f)
+ # TODO(michaelbai): Remove when crbug.com/547235 fixed.
+ sys.stderr.write("CopyFile: " + f + " " + dest + "\n")
jbudorick 2015/10/29 13:06:14 We do not want this in the build output.
michaelbai 2015/10/29 14:56:44 Let's keep it for a while, I did see 'CopyFile' bu
jbudorick 2015/10/29 14:57:29 No. Having builds making unnecessary noise is a pr
jbudorick 2015/10/29 15:03:19 Specifically, there'd be a crbug within hours abou
michaelbai 2015/10/29 17:00:45 Removed
def DoCopy(options, deps):
"""Copy files or directories given in options.files and update deps."""
« no previous file with comments | « base/android/java/src/org/chromium/base/ApkAssets.java ('k') | chromecast/chromecast.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698