Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: test/cctest/compiler/test-run-native-calls.cc

Issue 1424983003: [turbofan] Cleanup RawMachineAssembler::Store interface. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/compiler/test-run-native-calls.cc
diff --git a/test/cctest/compiler/test-run-native-calls.cc b/test/cctest/compiler/test-run-native-calls.cc
index 3574d731460f5d83b39c0803517e1d8ae10c8eac..e6c964929ba9714793f5b282d63524e174e8acd1 100644
--- a/test/cctest/compiler/test-run-native-calls.cc
+++ b/test/cctest/compiler/test-run-native-calls.cc
@@ -364,8 +364,8 @@ class ArgsBuffer {
Node* StoreOutput(RawMachineAssembler& raw, Node* value) {
Node* base = raw.PointerConstant(&output);
Node* offset = raw.Int32Constant(0);
- return raw.Store(StoreRepresentationForC<CType>(kNoWriteBarrier), base,
- offset, value);
+ return raw.Store(MachineTypeForC<CType>(), base, offset, value,
+ kNoWriteBarrier);
}
// Computes the next set of inputs by updating the {input} array.
@@ -577,8 +577,7 @@ static void CopyTwentyInt32(CallDescriptor* desc) {
Node* base = raw.PointerConstant(output);
for (int i = 0; i < kNumParams; i++) {
Node* offset = raw.Int32Constant(i * sizeof(int32_t));
- raw.Store(StoreRepresentation(kMachInt32, kNoWriteBarrier), base, offset,
- raw.Parameter(i));
+ raw.Store(kMachInt32, base, offset, raw.Parameter(i), kNoWriteBarrier);
}
raw.Return(raw.Int32Constant(42));
inner = CompileGraph("CopyTwentyInt32", desc, &graph, raw.Export());
@@ -1146,8 +1145,7 @@ void MixedParamTest(int start) {
}
Node* call = raw.CallN(desc, target, args);
- StoreRepresentation store_rep(sig->GetReturn(), kNoWriteBarrier);
- Node* store = raw.StoreToPointer(output, store_rep, call);
+ Node* store = raw.StoreToPointer(output, sig->GetReturn(), call);
USE(store);
expected_ret = static_cast<int32_t>(constant);
raw.Return(raw.Int32Constant(expected_ret));
« no previous file with comments | « test/cctest/compiler/test-run-machops.cc ('k') | test/unittests/compiler/arm/instruction-selector-arm-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698