Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: src/compiler/raw-machine-assembler.h

Issue 1424983003: [turbofan] Cleanup RawMachineAssembler::Store interface. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ports. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | test/cctest/compiler/c-signature.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/raw-machine-assembler.h
diff --git a/src/compiler/raw-machine-assembler.h b/src/compiler/raw-machine-assembler.h
index 9aa17df214aa1c6cc504671b9de25f2fffd7547e..be6bfb8f27a9b0cb25c462277c28b4c56e82fd69 100644
--- a/src/compiler/raw-machine-assembler.h
+++ b/src/compiler/raw-machine-assembler.h
@@ -126,12 +126,14 @@ class RawMachineAssembler {
return AddNode(machine()->Load(rep), base, index, graph()->start(),
graph()->start());
}
- Node* Store(StoreRepresentation rep, Node* base, Node* value) {
- return Store(rep, base, IntPtrConstant(0), value);
+ Node* Store(MachineType rep, Node* base, Node* value,
+ WriteBarrierKind write_barrier) {
+ return Store(rep, base, IntPtrConstant(0), value, write_barrier);
}
- Node* Store(StoreRepresentation rep, Node* base, Node* index, Node* value) {
- return AddNode(machine()->Store(rep), base, index, value, graph()->start(),
- graph()->start());
+ Node* Store(MachineType rep, Node* base, Node* index, Node* value,
+ WriteBarrierKind write_barrier) {
+ return AddNode(machine()->Store(StoreRepresentation(rep, write_barrier)),
+ base, index, value, graph()->start(), graph()->start());
}
// Arithmetic Operations.
@@ -498,8 +500,8 @@ class RawMachineAssembler {
Node* LoadFromPointer(void* address, MachineType rep, int32_t offset = 0) {
return Load(rep, PointerConstant(address), Int32Constant(offset));
}
- Node* StoreToPointer(void* address, StoreRepresentation rep, Node* node) {
- return Store(rep, PointerConstant(address), node);
+ Node* StoreToPointer(void* address, MachineType rep, Node* node) {
+ return Store(rep, PointerConstant(address), node, kNoWriteBarrier);
}
Node* StringConstant(const char* string) {
return HeapConstant(isolate()->factory()->InternalizeUtf8String(string));
« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | test/cctest/compiler/c-signature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698