Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1424943009: include what you use: errno.h in tools/android/ (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
Xianzhu
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h in tools/android/ Add missing errno.h includes. BUG=134180 Committed: https://crrev.com/bb2a1523fbd92c166a7c6749e4d7e3aefb05169f Cr-Commit-Position: refs/heads/master@{#358563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/android/forwarder2/pipe_notifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/forwarder2/socket.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mostyn Bramley-Moore
@Xianzhu: here are a couple of include-what-you-use fixes.
5 years, 1 month ago (2015-11-07 09:51:29 UTC) #2
Xianzhu
lgtm. Nit: Please add a BUG=134180 line in the description.
5 years, 1 month ago (2015-11-08 01:08:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424943009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424943009/1
5 years, 1 month ago (2015-11-09 02:46:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 03:53:21 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 03:53:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb2a1523fbd92c166a7c6749e4d7e3aefb05169f
Cr-Commit-Position: refs/heads/master@{#358563}

Powered by Google App Engine
This is Rietveld 408576698