Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1424943006: Support Windows FILE_FLAG_SEQUENTIAL_SCAN in base::File. (Closed)

Created:
5 years, 1 month ago by fdoray
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support Windows FILE_FLAG_SEQUENTIAL_SCAN in base::File. FILE_FLAG_SEQUENTIAL_SCAN is a hint to the system that a file will be read sequentially from beginning to end. It is required to pre-read modules efficiently. BUG=547794 Committed: https://crrev.com/2c32fabc2c602ee66bc63f9aec180ae60612302d Cr-Commit-Position: refs/heads/master@{#357151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/files/file.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
thestig@: Could you review this CL? Thanks. A reviewer recommended that I add this flag ...
5 years, 1 month ago (2015-10-30 16:56:29 UTC) #2
Lei Zhang
lgtm
5 years, 1 month ago (2015-10-30 17:25:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424943006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424943006/1
5 years, 1 month ago (2015-10-30 17:28:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 18:44:47 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 18:45:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c32fabc2c602ee66bc63f9aec180ae60612302d
Cr-Commit-Position: refs/heads/master@{#357151}

Powered by Google App Engine
This is Rietveld 408576698