Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1424943004: Move compiler cctests into v8::internal::compiler namespace. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move compiler cctests into v8::internal::compiler namespace. This moves all cctest files for the compiler to live in the same namespace as the components they are testing. Hence we can avoid the forbidden using directives pulling in entire namespaces. From the Google C++ style guide: "You may not use a using-directive to make all names from a namespace available". This would be covered by presubmit linter checks if build/namespaces were not blacklisted. R=bmeurer@chromium.org Committed: https://crrev.com/16f133001f3370ea7b8e6ee92b6827e67a14dd38 Cr-Commit-Position: refs/heads/master@{#31671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -86 lines) Patch
M test/cctest/compiler/codegen-tester.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-basic-block-profiler.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-branch-combine.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-multiple-return.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-operator.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsbranches.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsobjects.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-properties.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-stackcheck.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-stubs.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-variables.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-29 11:20:00 UTC) #1
Benedikt Meurer
LGTM
5 years, 1 month ago (2015-10-30 04:44:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424943004/1
5 years, 1 month ago (2015-10-30 09:06:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 09:16:30 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 09:16:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16f133001f3370ea7b8e6ee92b6827e67a14dd38
Cr-Commit-Position: refs/heads/master@{#31671}

Powered by Google App Engine
This is Rietveld 408576698