fpdfsdk/src/javascript/JS_Runtime.h - Issue 1424933013: Keep "static" objects per-context rather than per isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.h

Issue 1424933013: Keep "static" objects per-context rather than per isolate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nullptr Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Runtime.h

diff --git a/fpdfsdk/src/javascript/JS_Runtime.h b/fpdfsdk/src/javascript/JS_Runtime.h

index 4a55c2e9e6c303ee1b0a5d20b949a42120a5aea4..1bdd8e6fdd022d175c61ee9121ed10f508d1b57a 100644

--- a/fpdfsdk/src/javascript/JS_Runtime.h

+++ b/fpdfsdk/src/javascript/JS_Runtime.h

@@ -9,6 +9,7 @@

#include <set>

#include <utility>

+#include <vector>

#include "../../include/javascript/IJavaScript.h"

#include "../../include/jsapi/fxjs_v8.h"

@@ -71,6 +72,7 @@ class CJS_Runtime : public IJS_Runtime {

v8::Isolate* m_isolate;

bool m_isolateManaged;

v8::Global<v8::Context> m_context;

+ std::vector<v8::Global<v8::Object>*> m_StaticObjects;

std::set<Observer*> m_observers;

};

« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | fpdfsdk/src/javascript/JS_Runtime.cpp » ('j') | no next file with comments »