Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1424933012: Rename CFXJS_PrivateData to CFXJS_PerObjectData. (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename CFXJS_PrivateData to CFXJS_PerObjectData. Use m_ naming convention for its members. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b2dd2c96f6271a1520c36d707b626a34c72f7fb6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Static casts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 5 chunks +25 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, nothing but renames. This has been bugging me for a bit.
5 years, 1 month ago (2015-11-06 22:30:33 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1424933012/diff/1/fpdfsdk/src/jsapi/fxjs_v8.cpp File fpdfsdk/src/jsapi/fxjs_v8.cpp (right): https://codereview.chromium.org/1424933012/diff/1/fpdfsdk/src/jsapi/fxjs_v8.cpp#newcode482 fpdfsdk/src/jsapi/fxjs_v8.cpp:482: (CFXJS_PerObjectData*)pObj->GetAlignedPointerFromInternalField(0); Fix casting while we are here?
5 years, 1 month ago (2015-11-06 22:32:24 UTC) #4
Tom Sepez
https://codereview.chromium.org/1424933012/diff/1/fpdfsdk/src/jsapi/fxjs_v8.cpp File fpdfsdk/src/jsapi/fxjs_v8.cpp (right): https://codereview.chromium.org/1424933012/diff/1/fpdfsdk/src/jsapi/fxjs_v8.cpp#newcode482 fpdfsdk/src/jsapi/fxjs_v8.cpp:482: (CFXJS_PerObjectData*)pObj->GetAlignedPointerFromInternalField(0); On 2015/11/06 22:32:24, Lei Zhang wrote: > Fix ...
5 years, 1 month ago (2015-11-06 22:40:21 UTC) #5
Tom Sepez
5 years, 1 month ago (2015-11-06 22:41:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b2dd2c96f6271a1520c36d707b626a34c72f7fb6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698