Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1424933004: Changes in PaintLayer and PaintLayerPainter for synchronized painting (Closed)

Created:
5 years, 1 month ago by Xianzhu
Modified:
5 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes in PaintLayer and PaintLayerPainter for synchronized painting - Simplify ancestor marking of needsRepaint flags, because we have synchronzied whole layer-tree cleaning of the flags after painting. This removes the dependency of needs repaint flag to self-painting flag. - Don't output subsequence for non-self-painting layers. Previously we output subsequence for non-self-painting layers which has self-painting descendants. This reduces number of subsequences. - Don't output subsequences when printing because they are no use. - Don't output subsequence when painting overlay scrollbars to avoid duplicated display item ids and another tree of subsequences which just enclose overlay scrollbars. Covered by existing tests when synchronized painting is enabled. BUG=536999 Committed: https://crrev.com/5c2c5188dcc571c2a14ac424d7ade336ef99971a Cr-Commit-Position: refs/heads/master@{#357007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -21 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 2 chunks +5 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Xianzhu
5 years, 1 month ago (2015-10-29 23:07:02 UTC) #2
chrishtr
lgtm
5 years, 1 month ago (2015-10-29 23:11:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424933004/1
5 years, 1 month ago (2015-10-29 23:13:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 01:19:03 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 01:19:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c2c5188dcc571c2a14ac424d7ade336ef99971a
Cr-Commit-Position: refs/heads/master@{#357007}

Powered by Google App Engine
This is Rietveld 408576698