Issue 1424923007: Merge to XFA: Add test for CPDF_SyntaxParser::ReadHexString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1424923007: Merge to XFA: Add test for CPDF_SyntaxParser::ReadHexString. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add test for CPDF_SyntaxParser::ReadHexString. This CL adds tests for the ReadHexString method of the syntax parser. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1433503002 . (cherry picked from commit 71ad9a0028a183605fba734c48b4756d6caa7754) Committed: https://pdfium.googlesource.com/pdfium/+/eed2ee926d92f7cbc55b3e3d62a4a2cfddf0c3fd

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -2 lines)			Patch
M	BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	core/include/fpdfapi/fpdf_parser.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
A	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp	View	1	1 chunk	+170 lines, -0 lines	0 comments	Download
M	pdfium.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

dsinclair

5 years, 1 month ago (2015-11-03 19:32:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
eed2ee926d92f7cbc55b3e3d62a4a2cfddf0c3fd (presubmit successful).