Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: pydir/crosstest_generator.py

Issue 1424923005: Add workaround to allow testing of ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceAssemblerARM32.h » ('j') | src/IceClFlags.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pydir/crosstest_generator.py
diff --git a/pydir/crosstest_generator.py b/pydir/crosstest_generator.py
index dd72b805e6acda424f8defcec25f24449351bdc6..5b0040ba9aa7bf1f19d6243408bc27c73adc2cab 100755
--- a/pydir/crosstest_generator.py
+++ b/pydir/crosstest_generator.py
@@ -66,8 +66,8 @@ def main():
flat_attrs += v
arch_flags = { 'x8632': [],
'x8664': [],
- # ARM doesn't have an integrated assembler yet.
- 'arm32': ['--filetype=asm'] }
+ # ARM doesn't have a complete integrated assembler yet.
Jim Stichnoth 2015/11/04 01:01:09 I would change this comment to say that ARM doesn'
Karl 2015/11/04 16:02:39 Done.
+ 'arm32': ['--filetype=iasm'] }
# all_keys is only used in the help text.
all_keys = '; '.join([' '.join(targets), ' '.join(sandboxing),
' '.join(opt_levels), ' '.join(flat_attrs)])
« no previous file with comments | « no previous file | src/IceAssemblerARM32.h » ('j') | src/IceClFlags.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698